Checkbox Group confusion

Have Checkbox groups changed at all?

In the UI I add a checkbox group component, inside it I need to add a repeat children, with a checkbox inside that.
Like this.

<div is="dmx-checkbox-group" id="group_cb_booking_provider_company_products" name="group_cb_booking_provider_company_products" class="checkbox-group">
    <div id="repeat_cb_booking_provider_company_products" is="dmx-repeat" dmx-bind:repeat="sc_fetch_booking_provider_company_products.data.products_holder">
        <label class="form-check-label"><input class="form-check-input" dmx-bind:id="name ? name : internalName" type="checkbox" name="cb_group_booking_provider_company_products" dmx-bind:value="name ? name : internalName"> {{name ? name : internalName}}</label>
    </div>
</div>

{{group_cb_booking_provider_company_products.value}}

This works great and any checkbox clicked gets added as a comma separated value in the output, however I do not recall having to add a repeat children inside the checkbox group component, instead I used to add a repeat to the checkbox group itself I think.

Who knows maybe I am just confused, @Teodor have I done this correctly as Wappler intended?